Skip to content

Add Cost Management SDK#15469

Closed
bobalong79 wants to merge 1 commit intoAzure:mainfrom
Liverpool-Victoria:add-cost-management-sdk
Closed

Add Cost Management SDK#15469
bobalong79 wants to merge 1 commit intoAzure:mainfrom
Liverpool-Victoria:add-cost-management-sdk

Conversation

@bobalong79
Copy link
Copy Markdown

@bobalong79 bobalong79 commented May 30, 2021

Closes #15421

Requires Azure/azure-rest-api-specs#14600

SDK generation info:

$ git config --get remote.origin.url
https://github.com/Liverpool-Victoria/azure-rest-api-specs

$ git log -2
commit 891d96ad9090fae2e216dbcfc6d8c2f0af01fc2d (HEAD -> cost-management-updates, origin/cost-management-updates)
Author: Rob Long <Robert.Long@lv.com>
Date:   Sun May 30 12:37:59 2021 +0100

    Extend set of aggregation functions

    Add Avg, Max and Min to set of available aggregation functions.

    Signed-off-by: Rob Long <Robert.Long@lv.com>

commit 0b95154bd01e71b1759902bbbc7aecc6ce5b27fa
Author: Rob Long <Robert.Long@lv.com>
Date:   Thu May 27 15:52:50 2021 +0100

    Add typescript support to Cost Management

    Signed-off-by: Rob Long <Robert.Long@lv.com>

$ autorest --typescript --license-header=MICROSOFT_MIT_NO_VERSION --typescript-sdks-folder=../../../../azure-sdk-for-js/ --use=@microsoft.azure/autorest.typescript@4.4.4 --package-version=1.0.0 --tag=package-2019-11
AutoRest code generation utility [cli version: 3.2.1; node: v14.15.4, max-memory: 2048 MB]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
NOTE: AutoRest core version selected from configuration: ~2.0.4413.
   Loading AutoRest core      'C:\Users\lv33684\.autorest\@microsoft.azure_autorest-core@2.0.4419\node_modules\@microsoft.azure\autorest-core\dist' (2.0.4419)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.4.4->4.4.4)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

Signed-off-by: Rob Long Robert.Long@lv.com

Add Cost Management SDK
4f2da3e 
Signed-off-by: Rob Long <Robert.Long@lv.com>
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 30, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 30, 2021

Thank you for your contribution bobalong79! We will review the pull request and get back to you soon.

@check-enforcer
Copy link
Copy Markdown

check-enforcer Bot commented May 30, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

This was referenced Jun 1, 2021
Closed
Merged
@ramya-rao-a
Copy link
Copy Markdown
Contributor

ramya-rao-a commented Sep 1, 2021

@qiaozha, @nickzhums Can you please review?

@ramya-rao-a ramya-rao-a added the Mgmt This issue is related to a management-plane library. label Sep 1, 2021
@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Sep 3, 2021 •
edited
Loading

@jochav Previously, we want to release JS SDK for cost management but you have specifically tell us not to release it https://github.com/Azure/sdk-release-request/issues/1807#issuecomment-896341261 Now could you help answer @bobalong79 's question here. Thanks
If you still need it, you may file a release request via aka.ms/openapihub.

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Oct 29, 2021

close it as not getting any response. @jochav please file another sdk release request if you still need it. Thanks

@qiaozha qiaozha closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bterlson bterlson Awaiting requested review from bterlson

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees

No one assigned

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Cost Management SDK is missing

3 participants

@bobalong79 @ramya-rao-a @qiaozha